op-challenger: Make l2-eth-rpc and rollup-rpc required#10445
op-challenger: Make l2-eth-rpc and rollup-rpc required#10445
Conversation
Add rollupEndpoint to NewConfig signature since it was already always required.
WalkthroughWalkthroughThe updates primarily involve modifications to configuration handling and function calls across several test and utility files. The changes introduce additional RPC parameters and streamline endpoint management by removing specific endpoint dependencies in function calls. This refactoring likely aims to enhance flexibility and maintainability of the codebase, particularly in handling different network layers and configurations within testing environments. Changes
The table groups files by similar types of changes and uses ellipsis to shorten paths where detailed file paths are not crucial for understanding the scope of changes. Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (17)
Files skipped from review due to trivial changes (3)
Additional comments not posted (39)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10445 +/- ##
============================================
+ Coverage 42.31% 81.59% +39.28%
============================================
Files 73 10 -63
Lines 4838 1081 -3757
Branches 766 0 -766
============================================
- Hits 2047 882 -1165
+ Misses 2682 165 -2517
+ Partials 109 34 -75
Flags with carried forward coverage won't be shown. Click here to find out more. |
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Reduces so much duplication 💯
2 participants
Description
All trace types will require both
rollup-rpcandl2-eth-rpcoptions going forward.rollup-rpcwas already required, but not added to theNewConfigsignature.e2e tests are updated so they don't require specifying these endpoints in the
WithCannonandWithAlphabetoptions since they're already specified by the default config.Tests
Updated unit tests.
Metadata